test(estree): ESTree conformance check files with hashbangs#19680
Merged
graphite-app[bot] merged 1 commit intomainfrom Feb 24, 2026
Merged
Conversation
This was referenced Feb 24, 2026
github-actions
bot
added
the
C-test
This was referenced Feb 24, 2026
Member
Author
overlookmotel
added
A-linter-plugins
Contributor
There was a problem hiding this comment.
Pull request overview
This PR enables ESTree conformance tests for files with hashbangs by updating the estree-conformance submodule to include support for Oxc's non-standard hashbang property in the AST. Previously, these tests were skipped because the snapshots didn't include the hashbang field, causing mismatches.
Changes:
- Removed skip logic for hashbang tests in test262 and TypeScript ESTree conformance tests
- Updated estree-conformance submodule to commit 49d5664f which includes hashbang property support
- Updated test snapshots to reflect 10 additional test262 tests and 6 additional TypeScript tests now being tested
Reviewed changes
Copilot reviewed 1 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tasks/coverage/src/tools.rs | Removed skip conditions for test262 hashbang tests and 6 TypeScript test files with hashbangs |
| tasks/coverage/snapshots/estree_typescript_tokens.snap | Updated test counts (9761→9767) to reflect 6 additional tests |
| tasks/coverage/snapshots/estree_typescript.snap | Updated test counts (9761→9767) to reflect 6 additional tests |
| tasks/coverage/snapshots/estree_test262.snap | Updated test counts (46553→46563) to reflect 10 additional tests |
| tasks/coverage/snapshots/estree_acorn_jsx_tokens.snap | Updated commit hash to 49d5664f for estree-conformance submodule |
| tasks/coverage/snapshots/estree_acorn_jsx.snap | Updated commit hash to 49d5664f for estree-conformance submodule |
| .github/scripts/clone-parallel.mjs | Updated ESTREE_CONFORMANCE_SHA to 49d5664f to pull the updated submodule |
This was referenced Feb 24, 2026
This was referenced Feb 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Oxc's AST on JS side has a non-standard
hashbangproperty. Previously in ESTree conformance tests, we skipped files with a hashbang.Bump
estree-conformancesubmodule to include oxc-project/estree-conformance#183 which addshashbangproperty to AST in snapshots.We can now enable the tests which we previously skipped.